search

mapbox / mbutil

Importer and Exporter of MBTiles
http://mapbox.com/developers/
BSD 3-Clause "New" or "Revised" License
762 stars 199 forks source link

Should mb-util create JSON files for tiles that don't exist? #32

Closed schwanksta closed 7 years ago

schwanksta commented 12 years ago

Right now, mb-util creates many more JSON files than tiles. We could move the grid output code up to the tile output code so we only output a grid file if there is a tile. Does that sound like something worth a patch?

tmcw commented 12 years ago

Yeah, makes sense, can you write this?

schwanksta commented 12 years ago

Shouldn't be too complicated. I'll play with it later.

mikejcorey commented 10 years ago

Would love to see this happen -- well over half my export/upload time is blank grids a lot of the time.

tmcw commented 10 years ago

PRs accepted here - this is a fairly simple library and easy to change.

mikejcorey commented 10 years ago

I sent in a pull request, but it's failing a test. I think the test might now be invalid, however: It's looking for a grid that may not exist, depending on the data set.:

assert os.path.exists('test/output/imported/0/0/0.grid.json')

https://travis-ci.org/mapbox/mbutil/jobs/33538870

Of course I could also be reading that wrong.

sgillies commented 7 years ago

Closing due to inactivity.