mapbox / nepomuk

A public transit router for GTFS feeds (currently only static) written in modern c++

MIT License

24 stars 8 forks source link

Implement API Version 1 #115

Closed MoKob closed 7 years ago

MoKob commented 7 years ago

This PR aims at the implementation of #47 and #40.

removes the OSRM annotation/basic Trip annotation features.
reformat the api response to closely match the structure of the expected API (without the data duplication)
hides look-ups transparently
adds an API annotator to convert the transit result into the expected API result
... probably much more, which I haven't come up with yet.

jqtrde commented 7 years ago

Codecov Report

Merging #115 into master will increase coverage by 0.28%. The diff coverage is 97.15%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   95.84%   96.13%   +0.28%     
==========================================
  Files         122      129       +7     
  Lines        2626     2792     +166     
  Branches      231      224       -7     
==========================================
+ Hits         2517     2684     +167     
- Misses         18       23       +5     
+ Partials       91       85       -6

MoKob commented 7 years ago

The basic functionality is in. Will merge this PR and continue fleshing out the returned data in an additional PR.

We are missing a lot of the information about lines/station names...