Closed MoKob closed 7 years ago
Merging #151 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 127 127
Lines 2803 2803
Branches 224 224
=======================================
Hits 2696 2696
Misses 22 22
Partials 85 85
Using static libs for protobuf via mason is allowing a problem-free installation of our node bindings via npm. It comes at a price, though.
There is a heavy interaction between system includes and local includes, which seems to be confusing cmake a lot. I had to remove the link to
/usr/local/include
for osx builds, since the inclusion kept resulting in conflicting definitions between the system wide include path and the mason dependency (see https://github.com/Project-OSRM/node-osrm/issues/212 for reference).