How to keep santize.sh script in sync with the package.json `test` script? - Githubissues

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api

Creative Commons Zero v1.0 Universal

72 stars 10 forks source link

How to keep santize.sh script in sync with the package.json `test` script? #122

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

Currently the test config is duplicated in two places:

tape test/*.test.js at https://github.com/mapbox/node-cpp-skel/blob/84cea582881abf21b3ad6af71de88e8da09e71a9/package.json#L12
node node_modules/.bin/tape test/*test.js at https://github.com/mapbox/node-cpp-skel/blob/84cea582881abf21b3ad6af71de88e8da09e71a9/scripts/sanitize.sh#L54

The reason for the duplication is that, on OS X, DYLD_INSERT_LIBRARIES cannot be inherited by shells. So running npm test breaks.

We need to think of a way to ensure these don't get out of sync, otherwise you might end up with a scenario where:

sanitizers run 🍏 locally on OS X
sanitizers are broken on linux

because the OS X local build is not testing all the tests because the sanitize.sh script is out of date and not matching all test files.