search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Fix TOOLSET builds #138

Closed mapsam closed 6 years ago

mapsam commented 6 years ago

Resolves #137 by updating the --TOOLSET flag to --toolset which matches node-pre-gyp's expectations. More background in #137

Confirmed versions are publishing successfully over at https://travis-ci.org/mapbox/node-cpp-skel/builds/388725890

cc @millzpaugh @springmeyer @GretaCB @allieoop

springmeyer commented 6 years ago

goodness, thanks for catching this subtle cause of failure. I must have done a find and replace that was not case sensitive and should have been. Thank you.