search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Upgrade mason-js #141

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

The latest LLVM 6.0.0 package has a symlink inside it that trips up mason-js on OS X. Details at https://github.com/mapbox/mason-js/issues/58.

Once https://github.com/mapbox/mason-js/issues/58 is solved and we have a new release, we'll want to upgrade here immediately, and have downstream users to upgrade as well. NOTE: at this point the only downstream user of node-cpp-skel (that has updated post the mason-js support) is https://github.com/mapbox/vtcomposite.

springmeyer commented 6 years ago

No need to upgrade since we’ve solved this by upgrading llvm in #152