mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Integrate a tool for catching missing includes #142

Open sssoleileraaa opened 6 years ago

sssoleileraaa commented 6 years ago

Let's integrate a tool such as:

to catch missing includes that might not appear until Travis tries to build your code for a different OS, see https://travis-ci.org/mapbox/node-cpp-skel/builds/394326432 for example and notice how this builds for macOS but not Linux (this was due to missing #include <memory>).

Referencing @springmeyer's comment and tool suggestions here: https://github.com/mapbox/node-cpp-skel/pull/129#issuecomment-398533472