mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Remove -std=gnu++1y #145

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

Node v10 starts adding -std=gnu++1y to the inherited flags from node.js https://github.com/nodejs/node/blob/7bdc69426772a2915bc348f491aa7eaa44d422df/common.gypi#L348. This is problematic if we actually want to support c++14 for the compile of the addon, which we do. So, this fix will remove the node.js flag to avoid sending both flags to the compiler - refs https://github.com/mapbox/vtquery/issues/100