search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Return Buffer object with handoff from unique ptr string #147

Closed flippmoke closed 6 years ago

flippmoke commented 6 years ago

Added the ability to return the string as a buffer object instead for async methods with this buffer object handing off the result string rather then copying.

Related issue: #69

/cc @springmeyer @GretaCB

flippmoke commented 6 years ago

@GretaCB getting Unknown argument: polyglot from https://github.com/mapbox/node-cpp-skel/blob/master/package.json#L14

springmeyer commented 6 years ago

@GretaCB getting Unknown argument: polyglot from https://github.com/mapbox/node-cpp-skel/blob/master/package.json#L14

Per chat, this is because you need to install an older documentation-js version. @GretaCB can you make sure it is documented how to install the old version? (since I presume it is a big lift to deal with trying to get the newer version working and not something we have time for).

springmeyer commented 6 years ago

doc issue ticketed at https://github.com/mapbox/node-cpp-skel/issues/150 and worked around in f9fa032