search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Upgrade mason deps #152

Closed springmeyer closed 6 years ago

springmeyer commented 6 years ago

This includes clang++ and clang-tidy packages that both no longer symlink the c++ directory, which should avoid the (previous) problem with the llvm 6.0.0 packages mentioned at https://github.com/mapbox/node-cpp-skel/pull/146

refs https://github.com/mapbox/mason/pull/650

springmeyer commented 6 years ago

@alliecrevier would you be up for giving a quick review? We already did the hard work of upgrading the code to fix all LLVM 6.x clang-tidy issues (as I recall there were many) so this one looks easy. There was just one more place that 6.0.1 caught readability-redundant-member-init (and where 6.0.0 must not have been able to). And the fuchsia-default-arguments started throwing just with the creation of std::string(<data>) which indicates to me that google must not be using libstdc++ (no surprise). But because we do use libtstdc++ and we can easily avoid using std::string(<data>) I think the time has come to just ignore fuchsia-default-arguments.

sssoleileraaa commented 6 years ago

lgtm!