search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

100% code coverage #16

Closed springmeyer closed 8 years ago

springmeyer commented 8 years ago

We should get this repo to 100% coverage such that forks that don't start by adding coverage will explicitly decline/fail.

We need only very minor tests to get 100% coverage: https://codecov.io/gh/mapbox/node-cpp-skel/src/e44926c432cf2ee0c809a29da52541b0e0d35b38/src/hello_world.cpp

GretaCB commented 8 years ago

@gretacb and @springmeyer to finish this off. Looking at hello-world.cpp. Would allow future devs using skel to see their code coverage decrease as they add their own code.

GretaCB commented 8 years ago

@springmeyer Working off branch here https://github.com/mapbox/node-cpp-skel/tree/coverage

GretaCB commented 8 years ago

✅ per https://github.com/mapbox/node-cpp-skel/pull/28. Closing!

springmeyer commented 8 years ago

Great work @GretaCB. I'll now update the README to point to https://github.com/mapbox/cpp#code-coverage for more details on how this works.