mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

General CI conventions for travis/bitrise/circleci #20

Closed mapsam closed 7 years ago

mapsam commented 8 years ago

Per @mikemorris's comment:

I rigged up a script to only publish on git tags for mapbox-gl-native, but unfortunately it doesn't support Bitrise, as it relies on the TRAVIS_TAG environment variable. Figuring out some convention that works across Travis CI, Bitrise and Circle CI here would be great.

This would be rad.

springmeyer commented 7 years ago

I'm comfortable sticking with the 'commit message to publish' since, as mentioned, hooking into tags is ci platform specific. Mapbox GL Native does auto-publishing on tags and this recently broke and was tricky to fix when moving from travisci to circle. So, I'm going to close this as non-actionable with the additional thought that downstream developers could implement this but it currently feels out of scope for node-cpp-skel.