search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Use Async Workers for Heavy Async. Tasks #38

Closed daniel-j-h closed 7 years ago

daniel-j-h commented 7 years ago

This repository is great for getting people up to speed with Node bindings and Nan.

Let's switch over to Nan's AsncWorkers for async. tasks. It's simpler, clearer and less error prone then doing it ourselves with uv.

Somewhat related: #5.

cc @springmeyer

daniel-j-h commented 7 years ago

Fixed some remaining issues - Linux builds on Travis are green. Waiting for macOS builds (will take a while, will check tomorrow).

springmeyer commented 7 years ago

Thanks for working in this! I'll test on os x later today.

codecov-io commented 7 years ago

Codecov Report

Merging #38 into master will decrease coverage by -0.19%. The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   98.73%   98.55%   -0.19%     
==========================================
  Files           2        2              
  Lines          79       69      -10     
==========================================
- Hits           78       68      -10     
  Misses          1        1
Impacted Files Coverage Δ
src/hello_world.hpp 0% <ø> (ø) :white_check_mark:
src/hello_world.cpp 100% <100%> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6e8575a...76d5370. Read the comment docs.

daniel-j-h commented 7 years ago

Ping - just came across this again by accident, while checking out this project for its node-pre-gyp integration. What's the status here @springmeyer - anything blocking?

GretaCB commented 7 years ago

hey @daniel-j-h 👋 , thanks for getting this PR going! I'm currently refactoring the skel, and going to integrate AsyncWorkers in a new branch coming soon, stay tuned

daniel-j-h commented 7 years ago

Great, thank you! 👍

GretaCB commented 7 years ago

Implemented over at https://github.com/mapbox/node-cpp-skel/pull/46