search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

mason command not found in clang-tidy.sh #72

Closed mapsam closed 7 years ago

mapsam commented 7 years ago

I'm using .travis file over at mbtiles-geostats and hit the following error message on travis for the clang-tidy build:

$ make tidy
./scripts/clang-tidy.sh
./scripts/clang-tidy.sh: line 22: mason: command not found
make: *** [tidy] Error 127

Looks like mason isn't setup, because we skip this conditional.

cc @GretaCB

springmeyer commented 7 years ago

Thanks for catching this glitch! It is the same as #71 in that we need to add to the .gitignore. The local.env should not be committed to git, so removing https://github.com/mapbox/mbtiles-geostats/blob/master/local.env will fix this.

springmeyer commented 7 years ago

Solved by https://github.com/mapbox/node-cpp-skel/commit/34b915a8480cd00ffca0313d12ad951fb13565e4

springmeyer commented 7 years ago

@mapsam - fix also ported to https://github.com/mapbox/mbtiles-geostats/pull/10 for ya.