glitch in `make tidy` makefile command

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api

Creative Commons Zero v1.0 Universal

72 stars 10 forks source link

glitch in `make tidy` makefile command #76

Closed springmeyer closed 7 years ago

springmeyer commented 7 years ago

While forward-porting node-cpp-skel to https://github.com/mapbox/dawg-cache I noticed that the make tidy command failed oddly: https://travis-ci.org/mapbox/dawg-cache/jobs/283211159#L553

What looks to be happening is that node_modules may already exist in the directory such that the release target does not re-run the node_modules target: https://github.com/mapbox/node-cpp-skel/blob/c9f1e89249169258c538c4a0881ee00f1fc5b900/Makefile#L13

springmeyer commented 7 years ago

Turns out the travis job was using language: generic so the error was happening because a very ancient node.js version was being installed. Did not investigate what version, but using node v4 fixed the problem - now being done after f98233097