search

mapbox / node-cpp-skel

Skeleton for bindings to C++ libraries for Node.js using node-addon-api
Creative Commons Zero v1.0 Universal
72 stars 10 forks source link

Enable more default warnings #78

Closed springmeyer closed 7 years ago

springmeyer commented 7 years ago

We should have a more aggressive set of default warnings we enable.

refs mapbox/cpp#37

This brings node-cpp-skel in line with hpp-skel: https://github.com/mapbox/hpp-skel/blob/0af4ae29ec83fe12db20963fcd0855dbe7708a57/CMakeLists.txt#L22

/cc @GretaCB @mapsam

springmeyer commented 7 years ago

This is green on linux (osx is lagging). going to merge now without OS X.