search

mapbox / node-or-tools

Node.js bindings for or-tools vehicle routing problems
MIT License
147 stars 48 forks source link

Bump node-pre-gyp to ^0.12.0 to fix double rebuild bug #66

Closed ivosabev closed 5 years ago

ivosabev commented 5 years ago

This fixes a weird double rebuild bug described here: https://github.com/mapbox/node-pre-gyp/issues/444#issuecomment-474139956

ivosabev commented 5 years ago

Should support for Node 4.0 be dropped? It is like the IE6 of NodeJS?

danpaz commented 5 years ago

I agree with dropping node 4 as it's EOL for a while now. Can you rebase this PR and remove node 4 from the travis builds? Thanks!

coderroggie commented 5 years ago

@danpaz https://github.com/mapbox/node-or-tools/pull/68 includes the fixes mentioned above and removes node 4 from the travis builds.

danpaz commented 5 years ago

Replaced by #68