issues
search
mapbox
/
node-pre-gyp
Node.js tool for easy binary deployment of C++ addons
BSD 3-Clause "New" or "Revised" License
1.11k
stars
259
forks
source link
Fix 638 Test Failing with Node 16
#648
Closed
ronilan
closed
1 year ago
ronilan
commented
2 years ago
Overview
This pull request fixes #638.
Change
Removed
clang
flag from run command. Was breaking tests when run with npm 7.x and above (node 16, 18). See
issue comment
for error details.
Removed
env.bypass_s3_tests
conditional from tests. No longer needed.
Updated travis workflow no longer bypassing s3 tests.
Overview
This pull request fixes #638.
Change
clang
flag from run command. Was breaking tests when run with npm 7.x and above (node 16, 18). See issue comment for error details.env.bypass_s3_tests
conditional from tests. No longer needed.