Create GitHub Actions Test Setup

[ronilan]

Overview

This pull request introduces a GitHub Actions test setup that runs tests against both the mock S3 and a real S3 bucket. It also includes a beefed up NW.js test. The Action covers (roughly) all that is covered in the Travis and AppVeyor setups. It can run from any forked repo independent of Mapbox bucket setups (see: #613).

This pull request comes "on top" of (i.e. includes changes from) #651 (which in turn comes "on top" of #648, #649, #650).

Configuration

Running the tests against a real S3 bucket requires configuring the following repo secrets:

• AWS_ACCESS_KEY_ID
• AWS_SECRET_ACCESS_KEY
• S3_BUCKET

When not configured, the S3 tests are skipped.

Change

• Created GitHub Actions Test Setup (7b8b09a).

  • Added a GitHub Actions workflow that runs whenever there is a push to the repo.
  • Workflow includes two jobs:
    • A matrix job of node versions (10, 12, 14, 16, 18) and operating systems (Linux (ubuntu), Mac and Windows (2019 Enterprise)) that runs all tests against mock and then runs s3 tests against a bucket (located at us-east-1-bucket) specified as a repo secret.
    • A matrix job of and NW.js versions (0.64.0, 0.50.2) and node versions (10, 12, ,14, 16) that runs the NW.js test script.

• Modified existing configurations to work with GitHub Actions Test setup (4cbbc79).

  • Modified scripts/test-node-webkit.sh so that it can now accept an NW.js version as input. This allows running the script in a GitHub Actions matrix.
  • Modified test/run.util.js so that it does not set --msvs_version=2015 when running in GitHub Actions. This is required because current GitHub Actions runner do not support VS Studio 2015.
  • Added npm script command test:s3 to package.json that runs only the s3 tests. This is required because invoking npx tape test/s3.test.js on windows does not work as expected.
  • Modified test/proxy-bcrypt.test.js. Removed uneeded CI conditionals and modified download directory setup/cleanup. Latter was required due to concurrency issues with running tests on Mac, resulting in uncatchable errors during directory removal originating from rimraf.

Test

• All tests pass in all configurations (Local Mac, GitHub Actions, Travis, AppVeyor)

[ronilan]

Too many changes in a single PR.

It would be great to see a PR that only creates the GitHub Action. Other mods can be put into separate PRs once Appveyor and GitHub Actions are passing on modern versions of Node.js.

This one comes on top of #651. When #651 is merged all that is left in ##652 (this one) is the Push GitHub Action.