mapbox / node-pre-gyp

Node.js tool for easy binary deployment of C++ addons
BSD 3-Clause "New" or "Revised" License
1.11k stars 260 forks source link

run.util.js: Test building with msvs 2022 and get AppVeyor to pass #709

Closed cclauss closed 1 month ago

cclauss commented 3 months ago

To support newer versions of Node.js > v17

npm ci
npm run update-crosswalk

test/run.util.js

  if (process.platform === 'win32') {
-    final_cmd += ' --msvs_version=2015 ';
+    final_cmd += ' --msvs_version=2022 ';
  }

appveyor.yml

+ matrix:  # TODO: Fix the `configures with unparsed options` tests and remove this allow_failures matrix.
+   allow_failures:
+     - nodejs_version: 20
+     - nodejs_version: 21

AppVeyor test results: https://ci.appveyor.com/project/Mapbox/node-pre-gyp/history

@yhahn, @mapsam, @axrj, @rafaykh90, @ewanharris, @ronilan, @acalcutt Your reviews, please.

benmccann commented 1 month ago

Thanks for picking up this repo!

Please add the modifications from https://github.com/mapbox/node-pre-gyp/pull/709 so we can see if the tests pass on modern versions of Node.js.

I'm afraid I'm a little confused. Appveyor appears to be failing on that PR. Also, why don't we just merge it to master in if it does fix the build and then rebase the PRs against master?

cclauss commented 1 month ago

I rebased to get rid of the git conflicts.

cclauss commented 1 month ago

Done in other pull requests