Closed cclauss closed 1 month ago
Thanks for picking up this repo!
Please add the modifications from https://github.com/mapbox/node-pre-gyp/pull/709 so we can see if the tests pass on modern versions of Node.js.
I'm afraid I'm a little confused. Appveyor appears to be failing on that PR. Also, why don't we just merge it to master
in if it does fix the build and then rebase the PRs against master
?
I rebased to get rid of the git conflicts.
Done in other pull requests
To support newer versions of Node.js > v17
test/run.util.js
appveyor.yml
AppVeyor test results: https://ci.appveyor.com/project/Mapbox/node-pre-gyp/history
@yhahn, @mapsam, @axrj, @rafaykh90, @ewanharris, @ronilan, @acalcutt Your reviews, please.