mapbox / node-pre-gyp

Node.js tool for easy binary deployment of C++ addons
BSD 3-Clause "New" or "Revised" License
1.11k stars 260 forks source link

Error: Unsupported target versions: Node.js > v17 #710

Closed cclauss closed 1 month ago

cclauss commented 3 months ago

Proof:

The testing on this repo fails on all currently supported versions of Node.js but passes on end-of-life versions.

@springmeyer @ewanharris, @mapsam

ewanharris commented 3 months ago

@cclauss I think node-pre-gyp can be viewed as having no maintenance due to #657. I was never associated with the package, just made PRs as needed, and since that issue I ended up using patch-package to maintain updates to the abi_crosswalk.json file there, it's not ideal but AFAICT it's the only path forward for users right now.

At 6.5 million weekly downloads and >1000 dependents (across @mapbox/node-pre-gyp and node-pre-gyp) it's clear this package is well used in the ecosystem but given that mapbox no longer uses this software could it potentially be picked up in some manner by the Node.js project? There may be better alternatives now (n-api, prebuild) but I think it's important to avoid this package potentially falling into the wrong hands

cclauss commented 1 month ago

Fixed in #711 but perhaps not yet released. https://github.com/mapbox/node-pre-gyp/tags