search

mapbox / node-pre-gyp

Node.js tool for easy binary deployment of C++ addons
BSD 3-Clause "New" or "Revised" License
1.11k stars 260 forks source link

GitHub Actions: `npm run lint` #745

Closed cclauss closed 3 months ago

cclauss commented 3 months ago

% npm run lint

> @mapbox/node-pre-gyp@1.0.11 lint
> eslint bin/node-pre-gyp lib/*js lib/util/*js test/*js scripts/*js

/[...]/node-pre-gyp/test/build.test.js
  140:48  error  Missing semicolon  semi

/[...]/node-pre-gyp/test/proxy-bcrypt.test.js
  127:24  error  Missing semicolon      semi
  128:17  error  Empty block statement  no-empty

/[...]/node-pre-gyp/test/run.test.js
  170:73  error  Missing semicolon  semi
  214:77  error  Missing semicolon  semi

✖ 5 problems (5 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.
benmccann commented 3 months ago

I sent this in https://github.com/mapbox/node-pre-gyp/pull/746 with a couple of additional linting updates