mapbox / node-s2

bindings for s2 in node
88 stars 38 forks source link

NanCString deprecated #56

Closed DennisOSRM closed 10 years ago

DennisOSRM commented 10 years ago
warning: ‘char* NanCString(v8::Handle<v8::Value>, size_t*, char*, size_t, int)’ is deprecated (declared at ../node_modules/nan/nan.h:2285) 
DennisOSRM commented 10 years ago

similar to #37

DennisOSRM commented 10 years ago

From Nan's README:

NanCString() and NanRawString() have been deprecated in favour of new NanAsciiString, NanUtf8String and NanUcs2String. These classes manage the underlying memory for you in a safer way than just handing off an allocated array. You should now *NanAsciiString(handle) to access the raw char data, you can also allocate on the heap if you need to keep a reference.