search

mapbox / npm-internal

helps you package internal npm modules and upload them to your own s3 bucket.
MIT License
11 stars 3 forks source link

--dev should not use tags #22

Open ian29 opened 8 years ago

ian29 commented 8 years ago

im trying trying to deploy a branch of dynamosm-operator that uses a dev pacakge of dynamosm, but hitting a Expected version 0.6.0 of dynamosm but found 0.12.1 error from mbx deploy. this is because --dev first gets it's gitsha from git describe --tags rather than just reading package.json: https://github.com/mapbox/npm-internal/blob/master/index.js#L48

i think the ideal behavior would be to always always read the package.json version and never tags (assuming it's unlikely that if you're publishing a dev pkg that you've incremented the tag).

i can do a quickie PR that just removes https://github.com/mapbox/npm-internal/blob/master/index.js#L48 ?

@freenerd @karenzshea

freenerd commented 8 years ago

I think it should be fine to always use the package.json version. @mick watcha thinkin?

mick commented 8 years ago

@ian29 @freenerd sounds good to me