search

mapbox / npm-internal

helps you package internal npm modules and upload them to your own s3 bucket.
MIT License
11 stars 3 forks source link

Confusing non-failure without a git-fetch #25

Closed mapsam closed 7 years ago

mapsam commented 7 years ago

Since npm-internal relies on local git tags to name packages, you can end up with invalid versions unless you've recently git fetch'd to be in sync with the remote. For example:

My local repository has git tags up to version 0.12.0 but the remote version is all the way up to 0.18.2. When I npm-publish --dev the package name includes 0.12.0 even though the code is is synced with the most recent commit on the project.

It'd be great to either:

  1. add git fetch to the default command, to make sure the user is in sync with the remote
  2. add a warning message of some sorts, ensuring people are up to date with the remote

cc @GretaCB

mapsam commented 7 years ago

Oh this is a dupe-ish of #22 - looks like we could just not use tags