mapbox / osm-analysis-dashboard

OSM Analysis Dashboard
https://mapbox.github.io/osm-analysis-dashboard/
6 stars 4 forks source link

Things to ship for SOTM Asia #9

Closed ramyaragupathy closed 7 years ago

ramyaragupathy commented 7 years ago

Per discussion today listing down items, in order of importance, that needs to be shipped for the SOTM Asia presentation:

cc @planemad @rasagy @batpad @jenningsanderson @tridip1931

rasagy commented 7 years ago

Here is how the labels look above the tile cover:

readiness-labels

Easy option is to only let the city labels show up above the tile cover. The other (time consuming option) is to make a custom style using Light style with less prominent halos for high zoom labels. Thoughts?

rasagy commented 7 years ago
screenshot 2017-09-18 18 05 52

@jenningsanderson I noticed that there are edge cases where tiles of two zoom levels show up at once — is that intentional or should I fix that? (minzoom and maxzoom for layers should be integers — it seems Mapbox rounds it using ceil())

jenningsanderson commented 7 years ago

@rasagy - thank you! this was driving me a bit crazy, but hadn't investigated it yet; that's disappointing about the integers, because it creates a quick blink when it reloads, but yes, let's fix that.

ramyaragupathy commented 7 years ago

@rasagy I would stick to city labels above tile cover. As we zoom in, neighbourhood/place labels should be visible, but below the tile layer, so that it's not intrusive.

rasagy commented 7 years ago

that's disappointing about the integers, because it creates a quick blink when it reloads, but yes, let's fix that.

@jenningsanderson Yeah @batpad also liked how they showed up for a bit longer and hence made the zoom slightly smoother. I’m thinking of playing with the opacity as a ramp that could be based on min zoom and max zoom values. Will see if I can get it to work they way it is in my head.

@rasagy I would stick to city labels above tile cover.

@ramyaragupathy Added in https://github.com/mapbox/osm-analysis-dashboard/pull/10/commits/5e18ea09c07240e78ecbe132b7bfe446af9bc8b3

rasagy commented 7 years ago

@ramyaragupathy @jenningsanderson Would either of you be able to work on these:

Help text for each property in the sidebar — as a new field (desc?) for each property.

A link to resources (methodology, github repo) in the sidebar — This repo is private right now, so we should either make it public or host an about page somewhere else.

jenningsanderson commented 7 years ago

@rasagy Sounds good: let's use the desc field for each property to briefly describe what is being counted (and how it's being aggregated).

As for the about, resources, etc., I see two options:

  1. Since we have so much work-in-progress in the other repos, let's open this repo and use the Wiki (pulling stuff from the data-readiness wiki).
  2. We could also just make a static about page, but I think the wiki will be faster?

What do you think, @ramyaragupathy?

ramyaragupathy commented 7 years ago

👍 for the wiki on description & methodology @jenningsanderson.

rasagy commented 7 years ago

Specify min & max property values for legends. This can give a good overview on the range distribution for a particular property

We don’t calculate the max property in the actual data, but #16 implements showing the last stop for the property in the legend:

screenshot 2017-09-21 18 58 36

rasagy commented 7 years ago

Today’s focus:

jenningsanderson commented 7 years ago

:wave: @rasagy Excellent. I've fixed many of the problems with the current tilesets and am shooting to create these tilesets (readiness stats are currently generating):

Readiness tilesets should be done in the next 6-7 hours, then I'll create the final-aggregates and push them up to mapbox.

rasagy commented 7 years ago

Update:

jenningsanderson commented 7 years ago

Update with (https://github.com/mapbox/osm-analysis-dashboard/pull/23)

ramyaragupathy commented 7 years ago

Thanks for the support team, I was able to showcase the frontend in the talk.