search

mapbox / osm-bright

A Carto template for OpenStreetMap data
BSD 3-Clause "New" or "Revised" License
698 stars 225 forks source link

Issue during ./make.py #105

Open Amrizhan opened 9 years ago

Amrizhan commented 9 years ago

Hi there, when i tried to do ./make.py I have next error:

zhandos@root-osm:/usr/local/share/maps/style/osm-bright-master$ ./make.py Traceback (most recent call last): File "./make.py", line 123, in build() File "./make.py", line 41, in build template = loads(templatefile.read()) File "/usr/lib/python2.7/json/init.py", line 338, in loads return _default_decoder.decode(s) File "/usr/lib/python2.7/json/decoder.py", line 366, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode obj, end = self.scan_once(s, idx) ValueError: Expecting property name: line 8 column 19 (char 298)

line 8 in my osmbright is

from json import loads, dumps
DaviKaur commented 8 years ago

Code is correct. Check your file - /usr/local/share/maps/style/osm-bright-master/osm-bright/osm-bright.osm2pgsql.mml Check what you've edited, pasted in a correct way or not. Are you using proper delimiters at the end of "type":"shape". Similarly, are using correct property name. Check your file. These is no issue in code.

rikkitikkitumbo commented 8 years ago

ahh... for what it's worth I'm getting a similar error:

jeff@jeff-Inspiron-5749:~/Documents/mapbox-osm-bright-f1c8780$ ./make.py <open file 'osm-bright/osm-bright.imposm.mml', mode 'r' at 0x7fab16ed4db0> Traceback (most recent call last): File "./make.py", line 129, in build() File "./make.py", line 42, in build template = loads(templatefile.read()) File "/usr/lib/python2.7/json/init.py", line 338, in loads return _default_decoder.decode(s) File "/usr/lib/python2.7/json/decoder.py", line 366, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib/python2.7/json/decoder.py", line 382, in raw_decode obj, end = self.scan_once(s, idx) ValueError: Expecting property name: line 554 column 7 (char 26688)

I think they're talking about this line: "geometry": "point", "Datasource": { "type": "postgis", "table": "( SELECT geometry, type, name \n FROM osm_transport_points \n WHERE type='station'\n) AS DATA ", "key_field": "", "geometryfield": "geometry", "extent": "-20037508.34 -20037508.34 20037508.34 20037508.34", }, ***((((is line 554)))))_** "id": "train_stations", "class": "", "srs-name": "900913",

but it looks ok to me, so I'm not sure what to do

rikkitikkitumbo commented 8 years ago

Whoop!!! look at this:

"extent": "-20037508.34 -20037508.34 20037508.34 20037508.34", },

needs to be changed to: "extent": "-20037508.34 -20037508.34 20037508.34 20037508.34" }, (no comma after 34 there... this isn't important in javascript, but apparently it means something here...)

rikkitikkitumbo commented 8 years ago

Hey, I'm trying to make a custom map... Any advice? I've got myself up and running with this tutorial: https://tilemill-project.github.io/tilemill/docs/guides/osm-bright-ubuntu-quickstart/ but I'm wondering if there's something better out there than tilemill... it's pretty slow.