search

mapbox / osm-compare

Functions that identify what changed during a feature edit on OpenStreetMap.
ISC License
38 stars 15 forks source link

change user of pokemon_footway tests #183

Closed willemarcel closed 6 years ago

willemarcel commented 6 years ago

One test was failing on some timezones because the user 5008734 has account_created="2016-12-23T01:11:37Z", but moment.js is considering the timezone of the machine that is running the test. On my machine, for example, it prints that account_created date: moment("2016-12-22T23:11:37.000"). So I replaced the user 5008734 by the user 5017521, that was created on 2016-12-24T17:10:32Z.

batpad commented 6 years ago

Thanks for the catch @willemarcel !

Merging this now, but do you think there's a better way to fix this so that it isn't doing the timezone conversion and just using UTC or so so that we don't have this inconsistency of timezone of the machine the code is run on at all?