search

mapbox / osm-compare

Functions that identify what changed during a feature edit on OpenStreetMap.
ISC License
38 stars 15 forks source link

Add place_type_change comparator #202

Closed manoharuss closed 6 years ago

manoharuss commented 6 years ago

Added place type change comparator that checks for important places that have their type changed.

Important places are defined using version, place classification and existence of wikidata information

manoharuss commented 6 years ago

@amishas157 tried to debug but not able find the cause of the error on npm test. Can you do a quick review and flag where the error is occuring.

node tests/test_compare_function.js tests/fixtures/place_type_change.json works.

amishas157 commented 6 years ago

Hi @manoharuss , while debugging I found out that it was failing on basic fixtures i.e. feature will no old version or no new version. Therefore this commit https://github.com/mapbox/osm-compare/pull/202/commits/fcf7e7bb6444fa0a66ca1e877595782d78003c4d resolved it.

amishas157 commented 6 years ago

Thanks @manoharuss . It looks good now