Open rasagy opened 8 years ago
Here's a first shot: http://bl.ocks.org/ajithranka/d5f2e6328cafb32a0e724f71b147b139. Let me know what you guys think!
@ajithranka this is great! The main requirement now is a way for the reviewer to clearly identify the signage in the imagery:
cc @rasagy
@ajithranka theres one more enhancement that maintains feature parity with the JOSM plugin:
Implemented so far:
Blockers:
detection: true
in the mapillary viewer does not show boundsca
propertyBased on the early feedback from @ajithranka & @planemad, I’ll be updating the icons to look more prominent (brighter, bigger, darker halo). More design tasks on #63.
Updated the icons to look prominent, and to work well with the new bearing property added for #41 (no more equilateral triangles).
Right: Mapillary Photo that detects a restriction sign — normal & selected states Left: Other Mapillary Photo in the sequence (doesn’t detect a restriction sign) — normal & selected states
@rasagy the longer icon is definitely a more effective indicator of direction, so why have the smaller one at all? Can we just indicate the presence of a detected restriction with a minor modification to the base icon?
@planemad In the context of this map, the photos which detect the signage are much more important than other photos in the sequence, so I wanted to make sure they visually stand out + are easier to click. A trail can have a lot of photos that don’t detect the signage, so making the icon same for them will lead to much more noise.
Ex:
Also, by default only the photos that detect the signage are loaded when you tap on the detected signage:
And only on tapping on the large icon do you get the trail:
Do you still feel the difference in the icons should be reduced?
@rasagy 👍 the signage photographs are definitely more important and need to be easier to click. Just a size variation though seems hard to spot in a sea of similar shapes and orientation
Also now with the rotated symbols, we can tone down on the direction arrows on the trails which add a lot of noise:
This could be simpler chevrons that dont look clickable.
@planemad Let me experiment further on the colors for the two mapillary icon. Will try to dull down the other photo icons.
Also agreed about the direction arrows, they also seem to be clashing with one-way arrows which should be more important. Let me figure out where these icons are coming from in your style and update them to smaller grey arrow icons for Mapillary trails.
As highlighted during the shadow exercise with @srividyacb, the Mapillary photos play a major role in mapping & verifying turn restrictions. Making even minor improvements to the workflow should add up to make a significant difference.
Based on the discussion with @ajithranka & @planemad here are a few things that we need to relook/explore:
object
(estimated location of the signage), Mapillarysignage images
(that detect the specific signage/object), and remaining Mapillary images & trails — @rasagy to design iconsobject
— @planemad to hook up the sprites shared in #38 in the map stylebearing
for the Mapillaryobject
signage images
and remaining images usingbearing
property — @ajithranka to experiment with data-driven icon-rotate property@ajithranka & @planemad, can you add anything else that I might have missed?