mapbox / osm-wayback

Scalable RocksDB index from OSM planet to lookup historic OSM objects.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Timestamp Mismatch #19

Open jenningsanderson opened 7 years ago

jenningsanderson commented 7 years ago

The @timestamp field created by minjur is in seconds while OSM timestamps are strings.

Propose changing current @timestamp in current history objects to seconds. Human readable format is good for debugging, perhaps include a flag to keep a @created_at or @datestamp field?

{
  "type": "Feature",
  "geometry": {
    "type": "Point",
    "coordinates": [
      -122.2519108,
      37.7453841
    ]
  },
  "properties": {
    "@id": 53064457,
    "@type": "node",
    "@version": 4,
    "@changeset": 3523505,
    "@uid": 28775,
    "@user": "StellanL",
    "@timestamp": 1262471316,
    "highway": "turning_circle",
    "@history": [
      {
        "@timestamp": "2007-09-17T05:09:27Z",
        "@visible": true,
        "@user": "DaveHansenTiger",
        "@uid": 7168,
        "@changeset": 446628,
        "@version": 1,
        "@new_tags": {
          "source": "tiger_import_dch_v0.6_20070809",
          "tiger:tlid": "125005627:125038258",
          "tiger:county": "Alameda, CA",
          "tiger:upload_uuid": "bulk_upload.pl-9d5e179e-e488-4300-b71d-b0a82eacb273"
        }
      },
      {
        "@timestamp": "2008-05-02T00:39:37Z",
        "@visible": true,
        "@user": "quarl",
        "@uid": 36344,
        "@changeset": 307804,
        "@version": 2
      },
      {
        "@timestamp": "2010-01-02T22:28:36Z",
        "@visible": true,
        "@user": "StellanL",
        "@uid": 28775,
        "@changeset": 3523505,
        "@version": 4,
        "@del_tags": {
          "source": "tiger_import_dch_v0.6_20070809",
          "tiger:county": "Alameda, CA",
          "tiger:tlid": "125005627:125038258",
          "tiger:upload_uuid": "bulk_upload.pl-9d5e179e-e488-4300-b71d-b0a82eacb273"
        },
        "@new_tags": {
          "highway": "turning_circle"
        }
      }
    ]
  }
}