search

mapbox / pbf

A low-level, lightweight protocol buffers implementation in JavaScript.
BSD 3-Clause "New" or "Revised" License
796 stars 106 forks source link

Implementing the depreciated start and end groups types #110

Open kenttregenza opened 4 years ago

kenttregenza commented 4 years ago

As indicated here https://developers.google.com/protocol-buffers/docs/encoding The wire types of 3 and 4 (start and end groups) are "depreciated" ... but unfortunately they still exist on some protobuf packets floating around.

This could be easily resolved by adding these types and then update skip to include them (skipping zero bytes): else if (type === Pbf.StartGroup) this.pos += 0; else if (type === Pbf.EndGroup) this.pos += 0;

bulk88 commented 3 years ago

I agree, googleapis still return start and end groups.