Return Best Distance - Githubissues

mapbox / polylabel

A fast algorithm for finding the pole of inaccessibility of a polygon (in JavaScript and C++)

Other

1.44k stars 151 forks source link

Closed curran closed 4 years ago

curran commented 4 years ago

This PR is a proposed solution for #2.

A fresh take on #14.

Summary of changes:

Adds a distance property to returned values.
Includes changes to tests.
Guarantee that the distance value is 0, not -0, for degenerate cases.
Guarantee that there is always a value included for distance (never gets undefined).
Stick to ES5 (use var, and Object.assign in tests instead of rest/spread).

Kindly requesting review @mourner @fil . Feedback welcome!

🙏

curran commented 4 years ago

Thank you @Fil for reviewing!

I've made one more commit to address your idea. Requesting re-review please.

curran commented 4 years ago

Hooray!!! Thank you @mourner .

curran commented 4 years ago

@mourner Might it be possible to cut a new NPM release with this change? Thank you.

curran commented 4 years ago

Will mark that as deprecated when a new version of this upstream package comes out.