Closed who8mycakes closed 7 years ago
Should a random string of integers be added to the archive.* filename to differentiate between multiple archived files, or are individual outdirectories created per upload?
No need in this case, since each upload is its own separate job on the EC2. Even if more jobs were being run on the EC2 at a time, the dirname created is randomized.
@GretaCB Got the control flow issue sorted by nesting the functions:
I attempted to test this on staging today, however, testing was unsuccessful due to the lack of some environment credentials. I will take another stab at it tomorrow.
I was able to test this branch with the related bundle-fairy PR (https://github.com/mapbox/bundle-fairy/pull/9), and individual kml and gpx uploads were 🍏 , and the resulting zipped bundle included an archived file. I will run through some invalid bundles, kml, and gpx file test cases tomorrow.
@mapsam Can you please take a look here before I start finishing steps?
This PR adds steps to retain/archive the original KML or GPX file uploaded by a user.
Additionally, I added tests which assert:
@GretaCB Two questions I have are:
digest
be run against the infile before writing the contents toarchived.*
or does that create a file different from the original file?archive.*
filename to differentiate between multiple archived files, or are individual outdirectories created per upload?cc @mapbox/unpacker