search

mapbox / rio-rgbify

Encoded arbitrary bit depth rasters in pseudo base-256
MIT License
102 stars 38 forks source link

update travis, add pre-commit, add black, force rasterio 1.0... #24

Closed vincentsarago closed 4 years ago

vincentsarago commented 5 years ago

This PR does:

The only code change has been done to accommodate black/flake8

Right now tests are falling with because of different error code returned by click 

    def test_mbtiler_webp_badzoom():
        runner = CliRunner()
        with runner.isolated_filesystem():
            out_mbtiles = 'output.mbtiles'
            result = runner.invoke(rgbify, [in_elev_src, out_mbtiles, '--min-z', 10, '--max-z', 9, '--format', 'webp', '-j', 1])
>           assert result.exit_code == -1
E           AssertionError: assert 1 == -1
E            +  where 1 = <Result ValueError('Max zoom 9 must be greater than min zoom 10',)>.exit_code

cc @dnomadb

vincentsarago commented 5 years ago

I've updated the tests to adapt with the new exit code returned by click.

This is now ready for review.

sgillies commented 4 years ago

Are you still interested in this @vincentsarago? I've recently raised the idea of archiving this repo because the authors have moved on and it's unmaintained.

vincentsarago commented 4 years ago

👋 @sgillies Yes I'm still interested. What do you think about moving this one to github.com/rasterio ?

sgillies commented 4 years ago

Only if it's going to be maintained. I don't know if I have a use for it.

vincentsarago commented 4 years ago

Only if it's going to be maintained.

I can't promise anything, right now this is staling because no one has time to review accept PR... I know Mapbox folks have tons on their and so moving to a third party organisation with people from outside Mapbox could help IMO.

I don't know if I have a use for it.

Well if you see /rasterio user just for your use ... I'm happy to host rio-rgbify on /vincentsarago but it will make more sense to keep it in a third party organisation.

dnomadb commented 4 years ago

👋 @vincentsarago This repo is still useful for us be it still in the Mapbox organization or rasterio organization if it makes accepting PRs easier. I'm agnostic on this point but would lean towards keeping it and merging any PRs myself in the short term.