search

mapbox / rio-rgbify

Encoded arbitrary bit depth rasters in pseudo base-256
MIT License
99 stars 36 forks source link

populate mbtiles metadata with required fields #8

Closed andrewharvey closed 6 years ago

andrewharvey commented 6 years ago

Per the mbtiles-spec metadata fields are required.

closes #11

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.3%) to 94.681% when pulling 573b96e98f6be5654d1c172acd99d41fa1f02400 on andrewharvey:conform-to-mbtiles-spec into ba582bdad3d1513f358ecfad624aaf58b430f62c on mapbox:master.

andrewharvey commented 6 years ago

Thanks @dnomadb for picking up on that. I've made changes to address this so tests are now passing, but coverage decreased since I haven't added any tests. The current tests don't seem to actually open up the mbtiles file created to check everything is in order so without that testing infrastructure pre-existing and given I don't know Python I don't think there is much more I can do.

PS. Hoping that this makes it's way into Mapbox someday allowing customers to upload their own DEMs as Tilesets just like terrain-rgb.

andrewharvey commented 6 years ago

@dnomadb is this good to be merged or does it need more tests to push the coverage number up?

dnomadb commented 6 years ago

@andrewharvey sorry for the delay -- will publish asap.

dnomadb commented 6 years ago

https://pypi.python.org/pypi/rio-rgbify/0.3.2