Closed wboykinm closed 5 years ago
The parking handler right now really works for any polygons. What we need to do is
A generic polygon post-processing handler works as long as we don't want to do e.g. special case post-processing for buildings. Also for the zoom level generalization check https://github.com/mapbox/robosat/issues/51 and https://github.com/mapbox/robosat/pull/88.
What you can do for now is
--type parking
Or better give https://github.com/mapbox/robosat/pull/88 a try and see if it works for you.
@daniel-j-h I ran it as faux-parking per your suggestion above (I did not run the linked branch), and it threw this:
root@3d58a7d0d5c3:/app# ./rs features --type parking --dataset config/dataset-parking-middlebury.toml vt/rutland/masks/ vt/rutland/features/buildings-out.geojson
Traceback (most recent call last):
File "/usr/lib/python3.5/runpy.py", line 184, in _run_module_as_main
"__main__", mod_spec)
File "/usr/lib/python3.5/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/app/robosat/tools/__main__.py", line 60, in <module>
args.func(args)
File "/app/robosat/tools/features.py", line 41, in main
handler = handlers[args.type]()
File "/app/robosat/features/parking.py", line 26, in __init__
denoised = denoise(mask, self.kernel_size_denoise)
NameError: name 'mask' is not defined
Indeed, I don't see that param being handed in.
The mask
is passed in here
from the callsite here
Are you sure you didn't accidentally delete it or change something when removing the tile check?
I may well have. Also using a several-days-old, cpu-specific image at this point. Lemme update and try again.
@daniel-j-h Pulling the updates did the trick! Thanks!
I'd definitely love to see the generic polygon handler though; I'll be trying any number of feature types that are neither parking nor buildings.
Wish we can set type
,instead of updating code. Could you update features
command please?
@wucangeo see the branch in
https://github.com/mapbox/robosat/pull/88
then it should be easy to re-use the existing handler.
@daniel-j-h How rs features should work with roads detection? I am blocked on the pipeline here. Could you advice please?
You'd have to implement the featurization for roads first. I'm no longer with Mapbox or actively developing or maintaining this project; please talk to Mapbox folks if you have questions.
On May 13, 2020 1:46:44 PM UTC, Grifel79 notifications@github.com wrote:
@daniel-j-h How rs features should work with roads detection? I am blocked on the pipeline here. Could you advice please?
Currently the only supported option is
parking
, which is incompatible with inputs trained on buildings.Am I correct that this will require another well-thought-out postprocessing handler?