search

mapbox / robosat

Semantic segmentation on aerial and satellite imagery. Extracts features such as: buildings, parking lots, roads, water, clouds
MIT License
2.02k stars 382 forks source link

Fixes torchvision installation on travis #163

Closed daniel-j-h closed 5 years ago

daniel-j-h commented 5 years ago

In https://github.com/mapbox/robosat/pull/162 we upgraded torchvision and now need to install its pre-built wheel.

We forgot to change the Travis CI configurationto do the same. And because Travis does not run for my fork (since I can not push branches here..) we do not get continuous integration.

See errors in https://travis-ci.org/mapbox/robosat/jobs/538494380#L677

There is currently no way for me to test the Travis setup since it is configured to only build branches in this repository but not e.g. pull requests. @jacquestardie I don't have a good solution here other than you merging this and we see if it fixes things and if not we iterate. Or you folks grant me write access so we can remove the friction here and move forward with life.

jqtrde commented 5 years ago

🙂

I'm going to hold off merging here while I wait for some other happenings. Expect to have an update in a week or so.

Happy to merge otherwise if you don't want me to wait.

daniel-j-h commented 5 years ago

If you create a branch based on this branch and push it, Travis will build your branch.

It just does not build external pull requests right now. Maybe that's a quick way to see if it works on Travis instead of having to wait a week or so.

jqtrde commented 5 years ago

I think you should be able to merge here now @daniel-j-h.