Closed awiede closed 4 years ago
Updates address/unified search result parsing to accommodate the new nested suggestion list in single box search.
New schema can be parsed/viewed on the playground:
Reminder: We embrace the Search team's philosophy and approach to giving code reviews.
Suggestion: Prefix comments with [nit] if you believe they don't block the PR from being able to be merged.
[nit]
master
cc: @mapbox/search-federation
Summary of Changes
Updates address/unified search result parsing to accommodate the new nested suggestion list in single box search.
Testing Strategy
New schema can be parsed/viewed on the playground:
To Reviewers
Reminder: We embrace the Search team's philosophy and approach to giving code reviews.
Suggestion: Prefix comments with
[nit]
if you believe they don't block the PR from being able to be merged.Author's Questions/Concerns
Suggested Review Criteria
To Do Before Merging
master
cc: @mapbox/search-federation