search

mapbox / shapefile-fairy

I put a zipfile under my pillow and the fairy brought me shapefiles
ISC License
17 stars 6 forks source link

Descriptive errors. Fixes #13 #15

Closed tmcw closed 8 years ago

tmcw commented 8 years ago

Adds new error messages for missing and duplicate files, and new fixtures to test for them.

cc @GretaCB for the review

cc @lyzidiamond from a helping-users-debug perspective, is this the right level of specificity?

GretaCB commented 8 years ago

@tmcw looks good in staging :+1:

screen shot 2015-11-24 at 10 21 30 am

GretaCB commented 8 years ago

@tmcw I am in the process of fixing sem ver issues with tilelive in unpacker, so once I get that ready to go, I can merge/deploy this PR along with it.

GretaCB commented 8 years ago

All set to merge/deploy.

cc @lyzidiamond from a helping-users-debug perspective, is this the right level of specificity?

@lyzidiamond, stamp of approval?

lyzidiamond commented 8 years ago

@GretaCB @tmcw looking at this now

lyzidiamond commented 8 years ago

This is much clearer. :+1: from me.