Doku options types

[ximex]

look at the options.types.line. It should be: options.types.polyline

current:

var options = {
    folder: 'myshapes',
    types: {
        point: 'mypoints',
        polygon: 'mypolygons',
        line: 'mylines'
    }
}

correct:

var options = {
    folder: 'myshapes',
    types: {
        point: 'mypoints',
        polygon: 'mypolygons',
        polyline: 'mypolylines'
    }
}

[tmcw]

Have you tested this to be true? I haven't looked at this module in a while, but it really appears like the option would be called line.

[ximex]

look at:

• https://github.com/mapbox/shp-write/blob/master/src/zip.js#L22
• https://github.com/mapbox/shp-write/blob/master/src/geojson.js#L2

module.exports.line = justType('LineString', 'POLYLINE'); this "POLYLINE" is compared with the "line/polyline". Maybe change all "POLYLINE" and "line" to "LineString" as it is named in geojson

[tmcw]

Yes, but the code, as it currently stands, would work correctly with the example in the readme, and not with the suggested example, right?

[ximex]

options.types[l.type.toLowerCase()]

l.type.toLowerCase() = polyline options.types = {line: "mypolylines"} so: options.types["polyline"] = undefined but with: options.types = {polyline: "mypolylines"} options.types["polyline"] = mypolyline

the example in the readme didn't work for me. i have changed it that it works.