search

mapbox / shp-write

create and write to shapefiles in pure javascript
BSD 3-Clause "New" or "Revised" License
290 stars 186 forks source link

Fixed extraction of polygon coordinates #65

Closed hwbllmnn closed 2 years ago

hwbllmnn commented 6 years ago

This should fix #64 . Prior to this, for a given list of polygons from geojson write would have been called with one geometry (containing all other polygons) and n property objects, so only a single (multi-)geometry would be saved, but n entries in the .dbf.

newmanw commented 5 years ago

This fixes a bunch of outstanding issues. Any updates on if/when this will be merged in?

NickDarvey commented 5 years ago

Is this repository still being maintained and is this likely to be merged?

(We're looking for the fix to #66)

hwbllmnn commented 5 years ago

I don't think so. I've opened a maintenance branch at https://github.com/hwbllmnn/shp-write/tree/maintenance with some fixes I needed, feel free to use that one. If you have other issues/fixes feel free to do so at my fork, I'd be willing to do a little maintaining of my own.

aleffabricio commented 4 years ago

Hello @hwbllmnn, is it possible to merge solution #75 with your fork?

hwbllmnn commented 4 years ago

Sure, feel free to open a PR against the maintenance branch.

hwbllmnn commented 2 years ago

I don't think so. I've opened a maintenance branch at https://github.com/hwbllmnn/shp-write/tree/maintenance with some fixes I needed, feel free to use that one. If you have other issues/fixes feel free to do so at my fork, I'd be willing to do a little maintaining of my own.

Closing this PR as it won't be merged here.

sheindel commented 1 year ago

Hi all! I've been in discussion with the team from Mapbox and they've agreed to let me help take over some of the maintenance of this repo. I'd like to see some of these clearly important PRs merged in but I'll need some time to familiarize myself with them. Thanks for all the work you've all added so far and hopefully we can resurrect these projects!