Closed bsudekum closed 7 years ago
@1ec5 refactored this a bit as the main issue with the previous commit is that we were attempting to render a layer with type fill with a source of type LineString. This produced all sorts of strange rendering issues, most notably, not full filled polygons.
Now:
everytime we add a polygon, we also add a linestring already
Instead of representing the stroke as a separate feature, could we set fill-outline-color
to a value that accounts for both the strokecolor
and strokeopacity
options and represent the fill as a single feature?
@1ec5 yep, didn't know that value was possible.
mapbox/mapbox-gl-js#4088 proposes to remove the fill-outline-color
property altogether, but that won’t happen until the v9 style specification anyways.
Per discussion since there not a fill-outline-opacity
or fill-outline-width
, fill-outline-color
will not work.
To clarify, fill-outline-opacity
isn’t the problem, since fill-outline-width
accepts an RGBA value. The problem is that fill-outline-width
doesn’t exist.
This PR accounts for lines that have fill properties and also moves off of hat from cuid.
/cc @1ec5