search

mapbox / spritezero

small opinionated sprites
Other
173 stars 63 forks source link

Make sure heightAscThanNameComparator is transitive #29

Closed vdumont closed 8 years ago

vdumont commented 8 years ago

Just a small preventive fix. heightAscThanNameComparator isn't transitive as implemented, it shouldn't happen but if a and b were the same object then this would likely result in undefined behavior because a > b is true but b > a is also true.

tmcw commented 8 years ago

👍 Thanks @vdumont !