search

mapbox / spritezero

small opinionated sprites
Other
173 stars 62 forks source link

svgo should be more than just dev-dependency? #72

Closed andrewharvey closed 4 years ago

andrewharvey commented 4 years ago

68 introduced svgo into the library, however this was only made a dev-dependency. This causes issues when spritezero is a dependency of another library as it won't install svgo and will then crash when it can't find it.

It looks like either svgo will need to be a strict dependency or the methods that svgo requires pulled out of index.js?

@kkaefer

kkaefer commented 4 years ago

Yes, you're right. PR is in https://github.com/mapbox/spritezero/pull/73