Brutally large geometry

mapbox / tile-cover

Generate the minimum number of tiles to cover a geojson geometry

MIT License

189 stars 40 forks source link

Brutally large geometry #44

Closed yhahn closed 9 years ago

yhahn commented 9 years ago

[x] Create fixture/test/benchmark with NZ geom from quattroshapes
[x] Figure out strategies for speeding these suckers up

cc @morganherlocker

ian29 commented 9 years ago

see also: the chile file

yhahn commented 9 years ago

@morganherlocker https://github.com/mapbox/tile-cover/commit/236f4247bed7e1e951f8d8afb933c69f8bc6fdfe

This is greatly simplified from the orig geometry which is ~100MB as geojson : |

morganherlocker commented 9 years ago

per voice:

Add a limit of 50k coordinates per feature. 50k ought to be enough for anybody.
If 50k is not enough for somebody:
1. simplify the snot out of the offending feature (possibly add a buffer before hand to lean on the inclusive side with geocoder results)
2. split the geometry up and map/reduce over tile-cover
perform this check in the validator-worker

morganherlocker commented 9 years ago

moving this to carmen https://github.com/mapbox/carmen/issues/177

mourner commented 9 years ago

Does the algorithm really grow that fast?

morganherlocker commented 9 years ago

@mourner I believe so. There are still a few things we could do to speed it up (Active Edge Table has not been implemented yet), but generally 50 MB features are much larger than necessary for our current use cases.