mapbox / tilejson-spec

JSON format for describing map tilesets.
255 stars 52 forks source link

bounds #39

Closed mapsam closed 6 years ago

mapsam commented 6 years ago

This adds the bounds field to the Structure section, and includes some added text (in bold) from the current description:

The maximum extent of available map tiles. Bounds MUST define an area covered by all zoom levels. The bounds are represented in WGS:84 latitude and longitude values, in the order left, bottom, right, top. Values may be integers or floating point numbers. The minimum/maximum values for longitude and latitude are -180/180 and -90/90 respectively. Bounds MUST NOT "wrap" around the ante-meridian. If bounds are not present, the default value assumes the set of tiles is globally distributed.

The new addition covers questions from https://github.com/mapbox/tilejson-spec/issues/25 and https://github.com/mapbox/tilejson-spec/issues/23 at least for the v3 perspective, but they could be redefined in v4

cc @GretaCB

GretaCB commented 6 years ago

@mapsam

If bounds are not present, the default value assumes the set of tiles is globally distributed.

Per https://github.com/mapbox/tilejson-spec/pull/37#discussion_r185946346, should this specify MAY assume...?

mapsam commented 6 years ago

@GretaCB yes! Changing to

If bounds are not present, the default value MAY assume the set of tiles is globally distributed.

GretaCB commented 6 years ago

If bounds are not present, the default value assumes the set of tiles is globally distributed.

@mapsam Per the default value convo, how bout...

If bounds are not present, the default value MAY assume the set of tiles is globally distributed.

GretaCB commented 6 years ago

oh my goodness, de ja vous. Please disregard the comment above @mapsam . Seeing it was addressed per https://github.com/mapbox/tilejson-spec/pull/39#issuecomment-386750180

mapsam commented 6 years ago

@GretaCB no worries! A good reminder that including the text in the initial comment isn't terribly helpful after making updates 😄