search

mapbox / tilelive-overlay

Render GeoJSON features with simplestyle styles in a tilelive pipeline
ISC License
4 stars 13 forks source link

use mapnik-pool? #11

Closed tmcw closed 10 years ago

tmcw commented 10 years ago

@springmeyer does it make sense to use mapnik-pool with this module? would that give a perf boost?

springmeyer commented 10 years ago

Did not help before, but I can benchmark once more before we delete than branch.

yhahn commented 10 years ago

Pool would make sense if we were serving out a lot of tiles from the same map/data but it seems like most of the requests will be for one-offs from map/data instances. Worth a test though.

springmeyer commented 10 years ago

Agree @yhahn - not going to help and I don't think its worth testing. 60% of time is now in geojson parsing, with on 1% in acual XML parsing. Because the geojson is stored in-memory as part of the map object pooling maps would cache the geojson, but we'll not benefit from that.