Error handling tasks - Githubissues

mapbox / tilelive

fast interface to tiles with pluggable backends - NOT ACTIVELY MAINTAINED

BSD 3-Clause "New" or "Revised" License

532 stars 108 forks source link

Error handling tasks #15

Closed yhahn closed 8 years ago

yhahn commented 13 years ago

map pool will not throw/pass an error even if no resource is passed by acquire
https://github.com/mapbox/tilelive.js/blob/master/lib/tilelive/mappool.js#L29-31
Map.create is assumed to succeed during initialize() - if it fails it needs to be caught
https://github.com/mapbox/tilelive.js/blob/master/lib/tilelive/map.js#L115-117

springmeyer commented 13 years ago

one step forward in https://github.com/mapbox/tilelive.js/commit/9076f5867359d0fbe0f1e218d31b11eabfd765e6

springmeyer commented 13 years ago

The above commit was actually a step backward in certain cases whereby err is not an error object but rather an array of objects coming from carto (this appears to happen if reference.json changes and a old project is booted in tilemill with an invalid css property).

springmeyer commented 13 years ago

So, an error like:

$ ./bin/carto files/project/json/json.mml 
Unrecognized rule: point-width in /Users/dane/projects/TileMill/files/project/json/style.mss
5 #json {
6   point-width: 4;
7 }

Will bring down the whole server with:

node.js:63
    throw e;
    ^

@tmcw - can you advise on how to properly trickle up the carto errors without crashing all of tilemill?

springmeyer commented 13 years ago

see also https://github.com/mapbox/tilemill/issues/307 which is being caused by this lack of proper error handling.

springmeyer commented 13 years ago

see also: https://github.com/mapbox/tilelive.js/commit/2228c20736f79e5121102c093700b4de255eb417

yhahn commented 8 years ago

N/A