search

mapbox / tilelive

fast interface to tiles with pluggable backends - NOT ACTIVELY MAINTAINED
BSD 3-Clause "New" or "Revised" License
531 stars 108 forks source link

Test against node v0.10, v4, and v6 #196

Closed springmeyer closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.685% when pulling ccb05681628956f2a6f34cf0eb377f59a846be9b on node-v4-6-test into d9a0bdcb6263e6b9268be1e6a4415f1dd6b46898 on master.

springmeyer commented 7 years ago

Hmm, failing with:

not ok 230 round-tripped mbtiles are approx. the same size
  ---
    operator: ok
    expected: true
    actual:   false
    at: Put.makeAssertions (/home/travis/build/mapbox/tilelive/test/stream-deserialize.test.js:189:11)
  ...
springmeyer commented 7 years ago

Looks like this has been failing for a while. I notice as far back as https://github.com/mapbox/tilelive/pull/188

springmeyer commented 7 years ago

Don't have time to look into this test failure now, punting on this. Anyone please feel free to pick this up.

mapsam commented 7 years ago

@springmeyer I put this together yesterday in a separate PR: https://github.com/mapbox/tilelive/pull/195 - I didn't include node v0.10 though.

springmeyer commented 7 years ago

Thanks @mapsam - sorry for missing your PR! Closing this one.